lauriii / drupalcores

A project to generate a list of core contributers
http://drupalcores.com
MIT License
27 stars 38 forks source link

Development branch is now 8.5.x #105

Closed claudiu-cristea closed 6 years ago

wimleers commented 6 years ago

Failed with syntax error:

const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.

That seems to not have been introduced by this PR… so why this would fail, is a mystery to me.

fuzzbomb commented 6 years ago

@claudiu-cristea I'm proposing a different approach in #107, so we don't have to update the branch number every 6 months. Instead, we would just use whatever is marked as the default branch in the Drupal core repo. Would you like to review it?

borisson commented 6 years ago

Let's change this to the recently opened 8.6.x instead of 8.5 until #107 is in.

borisson commented 6 years ago

I think we can close this issue in favor of #108 or #107.

borisson commented 6 years ago

This can be closed, now that #107 is in.

alexpott commented 6 years ago

Fixed in #114