search

lauriii / drupalcores

A project to generate a list of core contributers
http://drupalcores.com
MIT License
27 stars 38 forks source link

Fix Travis test failures. #109

Closed fuzzbomb closed 6 years ago

fuzzbomb commented 6 years ago

Several pull requests have Travis test failures, due to a syntax error:

const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.

I found a solution at this StackOverflow answer - https://stackoverflow.com/questions/22603078/syntaxerror-use-of-const-in-strict-mode

This PR updates the version of NodeJS being used by Travis.

The change in the chalk module which caused it was https://github.com/chalk/chalk/commit/249b9ac7e75077de5fc9d8063df35918745e8471

fuzzbomb commented 6 years ago

Well at least these are different failures. The chalk.js syntax error is fixed.

Now it finished the "test" Gulp task, then stalls. It does this when running locally too, I don't know what the problem is here.

borisson commented 6 years ago

I've gotten it to work, but I'm unsure how to contribute to this PR. I created a new one in #111

fuzzbomb commented 6 years ago

@borisson Cool, you fixed it. Let's close this pull request in favour of #111