search

lauriii / drupalcores

A project to generate a list of core contributers
http://drupalcores.com
MIT License
27 stars 38 forks source link

Update template URL for contributor's commit list for gitlab (dynamically adjusting for correct branch) #129

Open mdlutz24 opened 4 years ago

mdlutz24 commented 4 years ago

Currently clicking on the number of issues takes you to the non-function pre-gitlab link.

This updates to a gitlab link, although we would have to update the head branch each minor.

lauriii commented 4 years ago

Sorry for the delayed feedback! I was on vacation for 2 weeks. We should try to find a way to automatically change the URL since it would be hard to keep this up to date. I would prefer removing the URL altogether temporarily given that it isn't working until we can figure out a way to create this link without requiring manual work.

mdlutz24 commented 4 years ago

I do agree, and not being a ruby developer, I didn't really try. I believe in json.rb we could parse the output of 'git remote set-head origin -a' or 'git remote show origin' to get the current HEAD branch, save that to data.json as a top level key and insert it into the template in cores.rb, but I will have to look up the syntax and methods needed to do that. Before I try, it does bring up an interesting question.

What do you want to do with this site when the D9 branch opens in a month or two?

Drop everyone to zero, and start counting again from the branch? Have separate lists for D8 and D9? Just keep going and rebrand slightly to keep track of contributions to drupal 8+?

mdlutz24 commented 4 years ago

Fair warning, this is the first Ruby code I've ever messed with, but I think this should do the trick to dynamically pick the correct branch. The questions regarding D9 strategy above are really unrelated and affect the whole counting algorithm and are way out of scope here. This just links to whichever branch we are counting from, which is the right thing to do.