search

lauriii / drupalcores

A project to generate a list of core contributers
http://drupalcores.com
MIT License
27 stars 38 forks source link

Remove usage of dollar sign #40

Closed pcambra closed 9 years ago

pcambra commented 9 years ago

I think it has a special meaning for ruby, a global variable or something, I'm guessing is a PHPism in here :)

lewisnyman commented 9 years ago

I had to revert this because it breaks the buildcompanies task:

Message:
    Command failed: ./companies.rb:51:in `ensure_company': undefined local variable or method `companies_info' for main:Object (NameError)
    from ./companies.rb:64:in `block in <main>'
    from ./companies.rb:61:in `each'
    from ./companies.rb:61:in `<main>'

Details:
    killed: false
    code: 1
    signal: null
    stdout: 
    stderr: ./companies.rb:51:in `ensure_company': undefined local variable or method `companies_info' for main:Object (NameError)
    from ./companies.rb:64:in `block in <main>'
    from ./companies.rb:61:in `each'
    from ./companies.rb:61:in `<main>'

Hopefully we will have TravisCI integration soon

pcambra commented 9 years ago

Ouch, this is being used as global at the end, I'll give another try to remove the need of a global.

What needs to happen to have TravisCI? happy to help.

pcambra commented 9 years ago

Can we reopen this? I still think it needs to happen

lewisnyman commented 9 years ago

Sure let's do that, I don't know if it's possible to remerge in the same pull request? Maybe we have to open a new PR?

pcambra commented 9 years ago

I'm testing it, I'll open a new PR with this