search

lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Layout margin / padding #113

Closed thamas closed 6 years ago

thamas commented 6 years ago

When the screen is narrower than the max with of the .container there is no default space between the edge of the screen and the content.

Eg.: https://monosnap.com/file/tVswF33hAyZfP5UnK8nHXj1rJwio4C#

We should decide if we add margin/padding to the .container or we mange this in component level for every related component. (It is done here and here but not everywhere.)

tomphippen commented 6 years ago

Hi @thamas

I've fixed this locally on just the .region-header. I do think doing it per component will make more sense as whether it's margin or padding will depend on the other styles.

Will push the change later this afternoon

Tom

thamas commented 6 years ago

Hi @tomhippen

It is great! Thanks!

markconroy commented 6 years ago

@tomphippen and @thamas can we close this issue?

tomphippen commented 6 years ago

Yes, if it does come up again it will need to be fixed per-component so would be a new issue.