search

lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Highlighted Small is using square ratio image, is this correct? #116

Closed kjays closed 6 years ago

kjays commented 6 years ago

In the design, all cards have images at ratio 3x2 except for the two top right of the home page, which have square. The current version of the theme uses square ratio on all Highlighted Small view mode cards. Am I right in thinking we need to change 'Highlighted Small' to use 3 x 2 ratio and introduce a new View mode for the 2 x small square ratio images on cards at the top of the home page?

markconroy commented 6 years ago

I'm setting hightlighted small to now use the 3:2 ratio. I'll create a new view mode for the sqaure ones on the homepage.

markconroy commented 6 years ago

Update - highlighted small now uses the 3:2 ratio, but I didn't create a new view mode.

So, the highlighted items at the top of the homepage are also using the 3:2 ratio.

Conversation here: https://drupal.slack.com/archives/C2HES6XQD/p1514995333000558