search

lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Breadcrumbs: Discuss in general, they were not included in the designs #126

Closed kjays closed 6 years ago

kjays commented 6 years ago

https://www.drupal.org/project/drupal/issues/2904243#comment-12405148

markconroy commented 6 years ago

For now, I am going to set breadcrumbs to not display on the homepage, but to display on all other pages.

This is a config change, so the code for that will be in the demo_umami repo.

markconroy commented 6 years ago

Breadcrumbs removed here - https://github.com/gareth-fivemile/demo_umami/commit/7a21f7edb055af1ad6b40006d0ac1cdd9fe6d531

Not sure if that fixes the issue - for some reason I can't see breadcrumbs on homepage on safari, chrome, or firefox.

markconroy commented 6 years ago

I've made some more changes to this, so that now the current page title is amended as a final (unlinked) breadcrumb.

it's on this commit

screen shot 2018-01-05 at 20 51 12

fuzzbomb commented 6 years ago

For accessibility, they help to address WCAG SC 2.4.8 Location

SC 2.4.8 is at WCAG level AAA, so technically we don't have to address it for our accessibility gate. I'd prefer to include it though, since Umami is about showcasing Drupal's features, which includes accessibility.

An alternative technique to address SC 2.4.8 is to provide a site-map, however Drupal core doesn't provide an easy way to do that, whereas breadcrumbs do come as part of core.