Closed cehfisher closed 6 years ago
I am seeing focus styles for buttons, but I think the issue is when a link is used instead of a true
Ex. page where this is happening: http://umami:8888/web/recipes The pink "button" is actually a link (using ). Ideally, this would use a
I think some HMTL was stripped out of your comment, so I can't exactly make sense of what you meant.
The pink "button" is actually a link
It behaves as a link, so <a>
is the correct element - that part is working fine. Do you think we should keep the "button" styling or make it more like the "View Recipe >" link style? There might be some button styling classes we can re-use.
I see a focus style on this link. In Firefox, it's the 1px dotted outline, so it's not a very obvious focus style. in Chromium it's the blue outline, and against the wooden table image, it's even harder to see than the Firefox one!
I have that banner button/link set like this now:
default:
hover/focus:
Is that enough for this issue to close?
Was the mark-up changed to
Hi Carrie,
I didn't change the markup, I just added a hover/focus state css to .block-banner-block .field--name-field-content-link a
. There is no button class there, it's just styling the (entity reference field) field.
I'm happy to take your lead on suggestions.
This is one of those "best case scenario" type of fixes. Your fix is a great start, but much more we could do in the future. I'd say either close this ticket and we can reopen at at later date, or add a tag indicating that this ticket is a future improvement.
I'll close for now, as issues are moving to Drupal.org.
Follow-up on d.o
Making a stand-alone ticket to tackle this accessibility issue.
From @fuzzbomb:
From @kjays: