lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Add icons to the message statuses #134

Closed cehfisher closed 6 years ago

cehfisher commented 6 years ago

Making a stand-alone ticket to tackle this accessibility issue.

From @fuzzbomb:

The message status (error, warning, info) are currently distinguished by colour alone. Icons would be the easiest solution here. I really like the full-width background, that could help draw attention to the message area.

From @kjays:

@thamas has done some work on this and simultaneously I did similar work but using the same link styles as the body area with colour variations. I need to re-implement my work for the links only since they conflicted on merge

thamas commented 6 years ago

@cehfisher It was done by #48

I checked again, icons are displayed, but link style has changed.

I close it but feel free to reopen if you see something to be done.

thamas commented 6 years ago

Output generated by styleguide module: screenshot-2018-01-05 11-44-06

cehfisher commented 6 years ago

Thanks for checking! It sounded like this might have been regressed on the last feature branch. Glad it was not. :)

fuzzbomb commented 6 years ago

The icons and underlined links in the screenshot above are the right idea.