search

lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Button erroneously has .visually-hidden class #139

Closed cehfisher closed 6 years ago

cehfisher commented 6 years ago

Need to review to see if this is still an issue and if there are any other instances of this bug.

From @fuzzbomb:

Something really confusing: there's a form_alter which adds .visually-hidden to the search form submit button. For a sighted keyboard user the button will be operable, but not perceivable. Could also cause difficulty for touch screen users, speech control, or users who input text with something other than a keyboard. A visible button is safer.

fuzzbomb commented 6 years ago

This one is high priority. We have a new design proposal in #119 which makes the button visible again.

thamas commented 6 years ago

Let's do it in #119!