search

lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Ensure menutoggle behaviour is only applied once. #144

Closed fuzzbomb closed 6 years ago

fuzzbomb commented 6 years ago

Fixes #143.

This PR uses jQuery.once() to ensure the menu button only gets one menutoggle click handler.

thamas commented 6 years ago

It updates an older version of the code. New version do not use neither jQuery nor Drupal.behaviors.

fuzzbomb commented 6 years ago

Which code should I be using for manual testing? I assumed it was the master branch here, which uses Drupal.behaviours

thamas commented 6 years ago

Active development happens on the dev branch. The code is this: https://github.com/lauriii/umami/commit/a15efc0b25c5aee7ee2ec57fb1f5723854e08db4 as I mentioned in the related issue: https://github.com/lauriii/umami/issues/143#issuecomment-355853161 :)