lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

H3 vs H4 heading styles #145

Closed cehfisher closed 6 years ago

cehfisher commented 6 years ago

Breaking this subtask off a comment from @lyndsey in #110. Can verify the margin is the only visual difference between the two headings.

H5 and H6 are fine now however in body content h3 and h4 are the same size (screenshot below). I have: h2 1.77rem h3 1.33rem h4 1.33rem h5 1.125rem h6 1rem

Suggestion: change h3 to 1.5 or 1.6rem. Tested this on a few pages and couldn't find a style issue with either size option.

headings

thamas commented 6 years ago

I found that 1.5rem fits better, so set that for h3.

screenshot-2018-01-08 11-52-46

cehfisher commented 6 years ago

Looks good to me locally. Thanks! (cc @lyndsey)