lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

Use extend to create menu-main.html.twig template #149

Closed thamas closed 6 years ago

thamas commented 6 years ago

Extend menu.html.twig instead of duplicating it.

tomphippen commented 6 years ago

Is the solution to this one editing menu.html.twig to add .setAttribute('data-drupal-selector',menu_classes) to level 0 menus and remove menu-main.html.twig.

It's the only difference in files and I can't see that it would have any negative effects if other menus get a data attribute

ckrina commented 6 years ago

Closing in favour of D.O. issue: https://www.drupal.org/project/drupal/issues/2936880