Closed markconroy closed 6 years ago
As I started to work on components using the markup (and class names) comes from classy I feel that there are a lot of stuff not needed for this design and also there are things that are not consistent. E.g. our CSS Coding Standards says that we should use BEM style class naming but I miss it some times or feel it is based on CMS logic not on thje logic of the comtent structure we have.
So if we want this theme not just for those who looks it from outside but for those too who check the code too we should refactor and clean up things to be able to say that we provide "best practices".
"We should use Classy as the base theme" – it was recorded to the meeting log from today.
Now that work has started we need to standardise on class names. So far I have been using the same class names that classy gives us. What are we going to use - classy, stable, none.
This was discussed in Vienna:
Pros for Classy (or stable):
Cons:
Thoughts?