search

lauriii / umami

[Deprecated] Umami is now included in Drupal Core. All further work happens there.
https://www.drupal.org/project/issues/drupal?component=Umami+demo
GNU General Public License v2.0
18 stars 5 forks source link

15--general-styles colors #83

Closed mariohernandez closed 6 years ago

mariohernandez commented 6 years ago

Updated color styles by implementing color swatches using brand colors.

colors

thamas commented 6 years ago

It is a much nicer display! Do not we need the contrast testing text which was in the color boxes?

lauriii commented 6 years ago

@thamas I'd assume we have various different possible text colors so I'm not sure if this is the best way to test the contrast.

kjays commented 6 years ago

Looks good. Mark created the text over coloured blocks as a way of running a test against the styleguide for accessibility contrast checks. I think there is a service that he is planning on using. However, the variations in the design for text over background colours are reasonably limited and perhaps if we include such a feature, it would make sense to limit the illustrations to just those in the designs. I can help on this when the time comes.

markconroy commented 6 years ago

This looks great. Mine was a quick solution and if we don't have many text on backgrounds it'll be easy to manually run tests.