search

laurilehmijoki / s3_website

Manage an S3 website: sync, deliver via CloudFront, benefit from advanced S3 website features.
Other
2.24k stars 187 forks source link

Use standard AWS SDK/CLI mechanism for credentials #262

Closed jeffbyrnes closed 7 years ago

jeffbyrnes commented 7 years ago

The “Configuring the AWS Command Line Interface” docs for the AWS CLI describe the various layers of configuration used for the CLI & the SDKs.

Rather than do an end-run around these, I propose it would be simpler (as it is built-in to the SDKs) t use these.

Specifically, to encourage use of either a credential file (~/.aws/credentials) or the environment variables (which override any credentials on disk). This would help avoid someone putting their credentials in a file that is easy to commit and publish by accident.

This even opens up the ability to use named profiles.

igilham commented 7 years ago

I agree. Adding credentials to the s3 sync config is not particularly helpful when so many other methods already exist and can be used more safely.

laurilehmijoki commented 7 years ago

Good idea! Pull requests appreciated.

jeffbyrnes commented 7 years ago

Guess I’ll try & learn some Scala!

jeffbyrnes commented 7 years ago

Thank you @pnc and @c0state for making this happen!