search

laurilehmijoki / tomcat7_rhel

Abandoned: Puppet Forge module for installing Tomcat 7 on RHEL 6
9 stars 11 forks source link

hyphens are legit in class names #4

Closed docwhat closed 11 years ago

docwhat commented 11 years ago

If you look at tomcat-application.pp you'll see that the hyphens in tomcat7_rhel::tomcat-application and tomcat7_rhel::tomcat-manager are highlighted in red.

My understanding of puppet is that hyphens in class names are not allowed.

AlexCline commented 11 years ago

According to the Puppet Language Guide:

Class names, module names, and the names of defined and custom resource types should be restricted to lowercase alphanumeric characters and underscores, and should begin with a lowercase letter; that is, they should match the expression [a-z][a-z0-9_]*.

laurilehmijoki commented 11 years ago

Thanks for pointing out the incorrect namings. Let's see how soon I have time to fix them and release a new backwards incompatible version.

laurilehmijoki commented 11 years ago

I converted the hypens into underscores. These changes are released in version 1.0.0, which breaks backward compatibility. See https://github.com/laurilehmijoki/tomcat7_rhel/blob/master/changelog.md#100 for how to migrate.