lausd-teacher / schooliki

Schooleaky stuff
0 stars 0 forks source link

Introducing Activies and Places for managing Browser History. #17

Closed zak905 closed 7 years ago

zak905 commented 8 years ago

I think it is better if we introduce Activities and Places for managing browser history. http://www.gwtproject.org/doc/latest/DevGuideMvpActivitiesAndPlaces.html

using History.addValueChangeHandler(..) is only suited for applications with a small number of routes. It will get unmanageable once the application grows. Now I see there is only this:

case "books": return;
        case "settings":return;
        case "calendars":return;
        case "lessons":return;
        default: loadMain();
            }//end switch
        }//end if single token 
                if(token.size()>= 2 && token.get(0).equalsIgnoreCase("roster")){
                    console.log("If token size 2 or greated called");
                    //first check id is kosher
                    //and then load display with id
                    for(int i =0; i < rosterList.length(); i++){
                        console.log("looping to compare ids");
                        if(Longs.tryParse(token.get(1))==rosterList.get(i).getId()){
                            console.log("If ids matched is called");
                            loadDisplay(token);
                            break;
                        }
                    }
                }
    }

Once we get more views completed, we will have lots of cases. Activities and places will come really handy.

lausd-teacher commented 8 years ago

Yeah I heard that you can't use gwt.runasync() with Activities and Places to really optimize the code. Again I was really afraid of load time. This is something we want on mobile

Get Outlook for Androidhttps://aka.ms/ghei36


From: Zakaria Amine notifications@github.com Sent: Tuesday, October 11, 2016 6:24:58 AM To: titanae/schooliki Subject: [titanae/schooliki] Introducing Activies and Places for managing Browser History. (#17)

I think it is better if we introduce Activities and Places for managing browser history. http://www.gwtproject.org/doc/latest/DevGuideMvpActivitiesAndPlaces.htmlhttps://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.gwtproject.org%2fdoc%2flatest%2fDevGuideMvpActivitiesAndPlaces.html&data=01%7c01%7ctdd6623%40lausd.net%7c3c90c9d687394455820708d3f1d9ff92%7c042a40a1b1284ac48648016ffa121487%7c1&sdata=SGfddfDzbYijZwjt1PcHnm%2fvFFyE8vllay%2bgtGlxdgY%3d

using History.addValueChangeHandler(..) is only suited for applications with a small number of routes. It will get unmanageable once the application grows. Now I see there is only this:

case "books": return; case "settings":return; case "calendars":return; case "lessons":return; default: loadMain(); }//end switch }//end if single token if(token.size()>= 2 && token.get(0).equalsIgnoreCase("roster")){ console.log("If token size 2 or greated called"); //first check id is kosher //and then load display with id for(int i =0; i < rosterList.length(); i++){ console.log("looping to compare ids"); if(Longs.tryParse(token.get(1))==rosterList.get(i).getId()){ console.log("If ids matched is called"); loadDisplay(token); break; } } } }

Once we get more views completed, we will have lots of cases. Activities and places will come really handy.

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2ftitanae%2fschooliki%2fissues%2f17&data=01%7c01%7ctdd6623%40lausd.net%7c3c90c9d687394455820708d3f1d9ff92%7c042a40a1b1284ac48648016ffa121487%7c1&sdata=2%2f6h4AtAScMKaS%2f1HoO%2fnQoWTSJUPEdFDzK8GluW0mI%3d, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fnotifications%2funsubscribe-auth%2fAMAgIoW0oKxtD1NxtRlOhlNVOPcARyZNks5qy44qgaJpZM4KTn8N&data=01%7c01%7ctdd6623%40lausd.net%7c3c90c9d687394455820708d3f1d9ff92%7c042a40a1b1284ac48648016ffa121487%7c1&sdata=narKf0We4JmjZ1mLbNAZk9EOoEC1T2EkvSzF5OoaqN4%3d.

videmantay commented 8 years ago

What do you think of GWTP? At least they have Async Presenters

zak905 commented 8 years ago

GWTP is a bit heavier, it makes use of Guice. I am not sure about gwt.runasync(), I think it's ok to use with Activities. Let me check.

videmantay commented 8 years ago

Then just get started with A & P . Again we can do optimization later.

On Tue, Oct 11, 2016, 7:50 AM Zakaria Amine notifications@github.com wrote:

GWTP is a bit heavier, it makes use of Guice. I am not sure about gwt.runasync(), I think it's ok to use with Activities. Let me check.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/titanae/schooliki/issues/17#issuecomment-252940185, or mute the thread https://github.com/notifications/unsubscribe-auth/ABsxr0DuDJ0U3hNucCLXszPi12YLwhndks5qy6IigaJpZM4KTn8N .

zak905 commented 8 years ago

Ok

zak905 commented 7 years ago

This is done