search

lausd-teacher / schooliki

Schooleaky stuff
0 stars 0 forks source link

Refreshing Browser breaks the app #32

Closed titanae closed 7 years ago

titanae commented 7 years ago

Hitting the refresh button on the browser breaks the app. This is because the app supposes that the user will start from login. I think we need to keep state in the history token so that the needed resources could be fetched. Something akin to rest.

example schooliki.com/teacher#roster/098098098/assigment/09809808098039

notice the resource ids after the entities just like in rest. that way when we refresh resources can be retrieved.

titanae commented 7 years ago

I guess there are other ways of keeping state? this is just my idea

zak905 commented 7 years ago

Normally, I keep track of all the things in the current context ( CurrentRoster, Students, Incidents,...) in the ClassRoomActivity class. This probably due to some reset of variables. I am going to investigate.

We can also make the app go back the main roster page when the page is refreshed, sounds good?

lausd-teacher commented 7 years ago

Yep that works

Get Outlook for Androidhttps://aka.ms/ghei36

From: Zakaria Amine notifications@github.com Sent: Wednesday, November 16, 2016 8:37:18 AM To: titanae/schooliki Subject: Re: [titanae/schooliki] Refreshing Browser breaks the app (#32)

Normally, I keep track of all the things in the current context ( CurrentRoster, Students, Incidents,...) in the ClassRoomActivity class. This probably due to some reset of variables. I am going to investigate.

We can also make the app go back the main roster page when the page is refreshed, sounds good?

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftitanae%2Fschooliki%2Fissues%2F32%23issuecomment-260997685&data=01%7C01%7Ctdd6623%40lausd.net%7Cf5c53bd85b164fdef8ab08d40e3ed62f%7C042a40a1b1284ac48648016ffa121487%7C1&sdata=RK7ffbFaKuaobf6jOshjc%2BYW8AOezBUaZTQN6FeNvaM%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMAgIpr-jAizhU9g5QD7cFdA9RP5-9D5ks5q-zE-gaJpZM4Kz9c-&data=01%7C01%7Ctdd6623%40lausd.net%7Cf5c53bd85b164fdef8ab08d40e3ed62f%7C042a40a1b1284ac48648016ffa121487%7C1&sdata=JGNwM5gz3DchRCJg3Iw3dyD1KVdMhRTfhToNp2zWgLE%3D&reserved=0.

zak905 commented 7 years ago

This issue is fixed.