search

lausser / GLPlugin

Perl modules providing the basis for my Naemon plugins
15 stars 28 forks source link

Enhancement for table_ascii and table_html #8

Closed sweitzel closed 8 years ago

sweitzel commented 8 years ago

I have modified table_ascii and table_html functions. These will be used by a separate pull request, e.g. for F5 LTM pool display or Interface table.

This is now more generalized:

sweitzel commented 8 years ago

sorry, closed a little late

sweitzel commented 8 years ago

will create branches in the future. Please let me know if you can accept this bundled PR for now...

lausser commented 8 years ago

I have no time to have a look at this stuff. And although GLPlugin is public, it's only purpose it to be the base for plugins i developed for my customers. I absolutely can not risk to break anything by introducing code changes to their installations.

sweitzel commented 8 years ago

Kein Problem, ich wollte nur was an die (1-Mann) Community zurückgeben und mich für deine Arbeit bedanken. Maybe later I have more time to extract definetly non-breaking stuff, like the MIB additions. I have just started using NWC this month and adjusted everything to my needs - as I dont know the others needs.

Hope you can still benefit from some of the changes for your customers.

lausser commented 8 years ago

Check_nwc_health runs at some of the biggest companies and in fact the development was driven by these customers‘ demands. (Lidl, Landeshauptstadt München, M-net,…). So it will not be possible to change the popups appearance, for example. But bug fixes are welcome any time, i’ll just needs some time to evaluate them and test if there are absolutely no side effects and even new bugs if a release is rolled out at these customers‘ sites. (Plus, the problem is, ConSol is a consulting company, which means there is no or very little spare time. In order to keep the company running, every hour of work must be paid by someone)

An alternative to pull requests is to work on check_nwc_health etc. all day long and even get some money for it :-)

https://www.consol.de/karriere/stellenmarkt/it-consultant-mw-mit-schwerpunkt-monitoring/

Von: Sebastian Weitzel [mailto:notifications@github.com] Gesendet: Freitag, 29. Juli 2016 19:39 An: lausser/GLPlugin Cc: Gerhard Lausser; State change Betreff: Re: [lausser/GLPlugin] Enhancement for table_ascii and table_html (#8)

Kein Problem, ich wollte nur was an die (1-Mann) Community zurückgeben und mich für deine Arbeit bedanken. Maybe later I have more time to extract definetly non-breaking stuff, like the MIB additions. I have just started using NWC this month and adjusted everything to my needs - as I dont know the others needs.

Hope you can still benefit from some of the changes for your customers.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lausser/GLPlugin/pull/8#issuecomment-236244681 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMJODW1hYK5eJaKbRU4fkCMUTmTWv5Aks5qajrNgaJpZM4JYNT0 . https://github.com/notifications/beacon/AAMJOOz1Dk7hivWHR2mZSLm9cup-3RO9ks5qajrNgaJpZM4JYNT0.gif