lausser
commented
7 years ago Please submit a pull-request
Von: snoep [mailto:notifications@github.com] Gesendet: Samstag, 5. November 2016 12:21 An: lausser/check_nwc_health check_nwc_health@noreply.github.com Betreff: [lausser/check_nwc_health] C3850 issues on chassis-hardware-health (#113)
Hi,
On version 5.9 of the check_nwc_health we have had two issues checking the stack-health on the C3850 switches from Cisco.
First problem was the unitalicized value on lines 22297 and 22298, the second was that a single switch reported a problem on chassis-health. We like to add all switches to this check since this will allow for unattended addition of switches to a single unit.
Both working fixes applied below.
Thanks Paul
--- check_nwc_health 2016-11-02 10:52:13.521056046 +0100 +++ ../../check_nwchealth 2016-11-05 09:22:04.889783895 +0100 @@ -22276,6 +22276,9 @@ foreach (@{$self->{switches}}) { $->check(); }
-
if (($self->{numSwitches} eq 1) && ($self->{numPorts} eq 2)) {
-
$self->{cswRingRedundant} = 'true'; -
} $self->add_info(sprintf 'ring is %sredundant', $self->{cswRingRedundant} ne 'true' ? 'not ' : ''); if ($self->{cswRingRedundant} ne 'true') { @@ -22294,9 +22297,9 @@ scalar(@{$self->{delta_lost_switchSerialList}}), join(", ", @{$self->{delta_lost_switchSerialList}})); }
-
if ($self->{delta_numPorts} > 0) {
-
if (($self->{delta_numPorts} ) && ( $self->{delta_numPorts} > 0)) { $self->add_warning(sprintf '%d new ports', $self->{delta_numPorts});
-
} elsif ($self->{delta_numPorts} < 0) {
-
} elsif (($self->{delta_numPorts}) && ($self->{delta_numPorts} < 0)) { $self->add_critical(sprintf '%d missing ports', abs($self->{delta_numPorts})); } if (! $self->check_messages()) {
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lausser/check_nwc_health/issues/113 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMJOBX_UFazdU8yx0hEn2pOR2BVPtMwks5q7GadgaJpZM4KqPAI .
Hi,
On version 5.9 of the check_nwc_health we have had two issues checking the stack-health on the C3850 switches from Cisco.
First problem was the unitalicized value on lines 22297 and 22298, the second was that a single switch reported a problem on chassis-health. We like to add all switches to this check since this will allow for unattended addition of switches to a single unit.
Both working fixes applied below.
Thanks Paul
--- check_nwc_health 2016-11-02 10:52:13.521056046 +0100 +++ ../../check_nwchealth 2016-11-05 09:22:04.889783895 +0100 @@ -22276,6 +22276,9 @@ foreach (@{$self->{switches}}) { $->check(); }