search

lausser / check_nwc_health

nwc = network component. This plugin checks lots of aspects of routers, switches, wlan controllers, firewalls,.....
http://labs.consol.de/nagios/check_nwc_health
GNU General Public License v2.0
149 stars 88 forks source link

F5 BigIP major versions are hardcoded, breaking now 14.x releases #205

Open pbiering opened 5 years ago

pbiering commented 5 years ago

there is a hardcoded F5 BigIP major version check which need to be updated after every major release appears...that's not a good idea...

Suggested fix will catch 10...99 and not only 10...13

@@ -52654,7 +52655,7 @@
   $self->{sysProductVersion} = $self->get_snmp_object('F5-BIGIP-SYSTEM-MIB', 'sysProductVersion');
   $self->{sysPlatformInfoMarketingName} = $self->get_snmp_object('F5-BIGIP-SYSTEM-MIB', 'sysPlatformInfoMarketingName');
   if (! defined $self->{sysProductVersion} ||
-      $self->{sysProductVersion} !~ /^((9)|(10)|(11)|(12)|(13))/) {
+      $self->{sysProductVersion} !~ /^((9)|([1-9][0-9]))/) {
     $self->{sysProductVersion} = "4";
   }
   if ($self->mode =~ /device::hardware::health/) {