search

lausser / check_nwc_health

nwc = network component. This plugin checks lots of aspects of routers, switches, wlan controllers, firewalls,.....
http://labs.consol.de/nagios/check_nwc_health
GNU General Public License v2.0
147 stars 87 forks source link

Redundant argument in sprintf #229

Closed distahl closed 4 years ago

distahl commented 4 years ago

Hi,
I'm getting this error, when using mode count-connections: 

Redundant argument in sprintf at ./check_nwc_health line 62826.
Redundant argument in sprintf at ./check_nwc_health line 62823.
WARNING - 537715 connections currently in use | 'connections'=537715;500000;750000;;

Additional Info:
check_nwc_health $Revision: 7.10.1.2 $

The lines causing this are: 

    $self->add_info(sprintf '%d connections currently in use',
        $self->{cfwConnectionStatValue}||$self->{cfwConnectionStatCount}, $self->{usage});

and: 

    $self->add_info(sprintf '%d connections currently in use',
        $self->{cfwConnectionStatValue}, $self->{usage});

And I guess the , $self->{usage} part has to be removed, to make this warning disappear. Would be great if you could fix this. Otherwise I'm forced to patch your script on every update myself again.

Thanks.

lausser commented 4 years ago

Thanks! Will be fixed in 7.10.1.7