search

lausser / check_nwc_health

nwc = network component. This plugin checks lots of aspects of routers, switches, wlan controllers, firewalls,.....
http://labs.consol.de/nagios/check_nwc_health
GNU General Public License v2.0
146 stars 88 forks source link

Wrong include causes problem in Classes/IFMIB/Component/InterfaceSubsystem.pm #294

Closed ironiq closed 2 years ago

ironiq commented 2 years ago

In commit 8396338 the cache file handling method was changed from Data::Dumper to JSON::XS. The problem is that the file in $subject includes only the "JSON" module and not the JSON::XS. Changing the line to "use JSON::XS" at least informs the user about the missing dependency if the given module is not installed. Otherwise the user will be informed that the interface-usage (and other modes in Classes::IFMIB::Component::InterfaceSubsytem) is not implemented ("UNKNOWN - Mode interface-usage is not implemented for this type of device").

einhander commented 2 years ago

@ironiq thank you! I've spent a whole day to figure that's wrong on my server, because in dev environment it works just fine.

ironiq commented 2 years ago

issue fixed with PR #299