lautaroangelico / WebEngine

WebEngine is an open-source, fast and secure CMS for private Mu Online game servers.
MIT License
113 stars 60 forks source link

Special Characters problem like using [ADM] or [YTB] tag #55

Open rooanoliveira opened 2 years ago

rooanoliveira commented 2 years ago

When use [] characters some things doesnt work, like Profile, Character Editor for example.

lautaroangelico commented 11 months ago

@rooankesley Can you provide some screenshots of where exactly the error is happening? Please provide full instructions on how to reproduce this issue.

rooanoliveira commented 11 months ago

https://streamable.com/7za7vr

1 - Create character using name [ADM]XXXX 2 - try to access profile of this character, because of "[" and "]" characters you cannot access them, problem with special characters, probably sabe problem with another ones...

i think its good make link coded to avoid something like that.... [ADM]XXXX > Base64 > W0FETV1YWFhY

lautaroangelico commented 11 months ago

@rooankesley most mu servers don't allow those special characters to be used, and it is recommended not to allow them. At the moment player names are filtered for alphanumeric characters, you can remove such filter and allow those special characters by modifying the following files: https://github.com/lautaroangelico/WebEngine/blob/master/.htaccess https://github.com/lautaroangelico/WebEngine/blob/master/includes/classes/class.profiles.php#L56