search

lautenberger / elmfire

Eulerian Level set Model of FIRE spread
https://elmfire.io
Eclipse Public License 2.0
30 stars 13 forks source link

Seg fault when RANDOM_IGNITIONS=.TRUE. and USE_IGNITION_MASK = .FALSE. #37

Closed lautenberger closed 11 months ago

lautenberger commented 1 year ago

This issue is moved here from issue #34 because it is a distinct issue. The original report from @johnsonas6 was that the following input deck caused a runtime segmentation fault:

https://drive.google.com/drive/folders/1bZWmxapb1BopR1CBKafQXWeyiYP8_uCF?usp=drive_link

I was able to reproduce this behavior locally and determined that it was due to the use of RANDOM_IGNITIONS=.TRUE. with USE_IGNITION_MASK = .FALSE. in elmfire.data. The keyword USE_IGNITION_MASK is scheduled for removal and until then this combination will now (as of commit https://github.com/lautenberger/elmfire/commit/6b94c73ce2e55336292a9ea41176a86f90b9f84e) cause a descriptive error message to be emitted to prevent a run time seg fault.

Until USE_IGNITION_MASK is removed, when RANDOM_IGNITIONS = .TRUE. the user should set USE_IGNITION_MASK = .TRUE. and specify a Float32 ignition mask using the keyword IGNITION_MASK_FILENAME on the &INPUTS namelist group.

lautenberger commented 1 year ago

@johnsonas6 can you try running this again and let me know what the prognosis is? You should be able to create an ignition mask raster by copying adj.tif to ignition_mask.tif or similar.

lautenberger commented 11 months ago

Closing this issue due to inactivity.