Closed yqin123 closed 1 year ago
Hi Yiren,
Thanks for the PR, confirming receipt. I will review this shortly and provide comments or get it merged.
Best,
Chris
Since ELMFIRE tracks smoke emissions, to avoid confusing smoke emission with ember emission, for anything to do with spotting I suggest we replace variable names containing EMISSION with EMBERGENERATION or EMBERGEN for short.
I suggest changing TIME_TO_IGNITE to EMBER_TIGN to make it clear it's from embers since there are other mechanisms through which a grid cell can ignite such as a point ignition
I like the variable name EMBER_SAMPLING_FACTOR
instead of N_PHYSIC_EMBER_PER_NUMER
- this is consistent with terminology used in FDS.
Changing the variable FOOTPRINT_PERCENTAGE
to BLDG_FOOTPRINT_FRAC
I'm adding the source file elmfire_spotting_superseded.f90
which contains the (to be) superseded spotting functions SPOTTING_SUPERSEDED
and EMBER_TRAJECTORY_SUPERSEDED
. The keyword USE_SUPERSEDED_SPOTTING
(.TRUE. by default) can be set to .FALSE. to enable the spotting algorithm enhancements in this PR. I'd like to do it this way to isolate the updated spotting algorithm so that we can quantify its improvements relative to the old spotting algorithm.
Thanks for the PR, Yiren. As you'll see above I adjusted a few variable names, made some tweaks, and isolated the new spotting treatment with the &SPOTTING
keyword USE_SUPERSEDED_SPOTTING
. Merging.
Hello Chris,
I modified the UMD spotting model by:
P_EPS
in theSPOTTING
namelist. It truncates Sardoy's PDF at the corresponding percentile.FOOTPRINT_PERCENTAGE
in theINPUTS
namelist. It is the portion of the structural area to the pixel area and is assumed to be constant (for fully occupied,FOOTPRINT_PERCENTAGE=1
). A raster input may be better in the future. This option is activated using the parameterUSE_PHYSICAL_SPOTTING_DURATION
in theSPOTTING
namelist.USE_PHYSICAL_EMBER_NUMBER
in theSPOTTING
namelist. ParameterN_PHYSIC_EMBER_PER_NUMER
in theSPOTTING
namelist controls the number of real embers each Lagrangian particle represents.CLEAR_USED_EMBER
to clear expired embers being tracked in the structSPOTTING_STAT
. However, it does not fully solve the problem of saving a lot of particles simultaneously whenEMBER_GR
is high.FAST_SPOTTING
in moduleelmfire_spotting.f90
. However, it also suffers the problem of allocating a huge array. It has not been tested yet and is not functional in the current code. A parameterSE_SPOTTIN_LOOKUP_TABLE
inSPOTTING
namelist is added to activate this option in the future.DUMP_SPOTTING_OUTPUTS
to dumpSPOTTING_STAT
for embers responsible for igniting new pixels. By default, it is set to.FALSE.
.tutorial
folder as05-UMD-spotting-model
.Most of the modifications are in module
elmfire_spotting.f90
.elmfire_level_set.f90
is modified to call subroutines inelmfire_spotting.f90
. Let me know if there are any problems.Yiren