search

lauthieb / ngx-konami

A simple directive to add easter eggs in your Angular application 👾
MIT License
36 stars 6 forks source link

Ivy / Angular 9 compatibility #4

Closed matcho closed 4 years ago

matcho commented 4 years ago

Hi,

I just updated my Angular 8 app to v9, and I get the following error when building.

ERROR in node_modules/ngx-konami/index.d.ts:3:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class

export declare class KonamiModule {
                       ~~~~~~~~~~~~

From what I understood it's probably linked to the use of Ivy compiler by default with Angular 9, and the fact that it is not compatible with minified and/or compiled es5 code (not sure of that part). See: https://github.com/angular/angular/issues/35255

Disabling Ivy in tsconfig does the trick so it's not such a big deal, but maybe it still could be made Ivy-compatible ?

Thanks

bfaulk96 commented 4 years ago

Any maintainers available to look over @matcho's PR?

lauthieb commented 4 years ago

Thanks @matcho & @bfaulk96!

Hello 1.7.0 🎉 https://www.npmjs.com/package/ngx-konami