search

lautis / uglifier

Ruby wrapper for UglifyJS JavaScript compressor.
http://www.rubydoc.info/gems/uglifier
MIT License
613 stars 82 forks source link

Update from 2.7.1 to 2.7.2 broke scripts #87

Closed brunoluigi closed 8 years ago

brunoluigi commented 9 years ago

Don't know what happened but the my scripts uglified with 2.7.2 breaks while everything works fine with the 2.7.1 =/

I know this issue report is not very helpful right now but I'll update it with more info as soon as I can =)

lautis commented 9 years ago

@brunoluigi, have you managed to find anything on this? I'd guess that there could be a regression with UglifyJS update.

toncid commented 9 years ago

@brunoluigi Are you using AngularJS? Uglifier seems to misinterpret something in there...

brunoluigi commented 9 years ago

Yep, we're using AngularJS here =)

toncid commented 9 years ago

@lautis Thoughts?

lautis commented 9 years ago

Some more information about the breakages, Angular setup and Uglifier setup would be helpful.

My first guess would be to look at function argument name mangling. Do you have it enabled (it's by default)? If so are you using ng-annotate or @ngInject to deal with dependency injection when minifying? This isn't very specific to the changes between 2.7.1 and 2.7.2 though :/

As UglifyJS 2.5.0 was released few days ago, it might be worth trying if that would fix the issues.