fixed a small bug in the adrf neuron forward function - Githubissues

lava-nc / lava-dl

Deep Learning library for Lava

https://lava-nc.org

BSD 3-Clause "New" or "Revised" License

149 stars 71 forks source link

fixed a small bug in the adrf neuron forward function #308

Closed felixthoe closed 3 months ago

felixthoe commented 3 months ago

Issue Number: #277

Objective of pull request: Small bug fix, I changed self.spike(real, imag, threshold + refractory) to self.spike(real, imag, threshold, refractory)

Pull request checklist

Your PR fulfills the following requirements:

[x] Issue created that explains the change and why it's needed
[ ] Tests are part of the PR (for bug fixes / features)
[ ] Docs reviewed and added / updated if needed (for bug fixes / features)
[x] PR conforms to Coding Conventions
[ ] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
[ ] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
[ ] Build tests (pytest) passes locally

Pull request type

Please check your PR type:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation changes
[ ] Other (please describe):

What is the current behavior?

There seems to be a small bug in the implementation of the adrf neuron (lava-dl/src/lib/dl/slayer/neuron/adrf.py). The Neuron.forward() function calls self.spike(real, imag, threshold + refractory), while it should be self.spike(real, imag, threshold, refractory) according to the definition of the function Neuron.spike() in the same file. This results in a TypeError because the last positional argument is missing in the function call.

What is the new behavior?

The function call is now executed with the four parameters as four positional arguments, as intended.

Does this introduce a breaking change?

[ ] Yes
[x] No

Supplemental information