Fix refract_counter init in NEBM/NEBMSA - Githubissues

lava-nc / lava-optimization

Neuromorphic mathematical optimization with Lava

https://lava-nc.org/optimization.html

BSD 3-Clause "New" or "Revised" License

51 stars 26 forks source link

Fix refract_counter init in NEBM/NEBMSA #223

Closed AlessandroPierro closed 1 year ago

AlessandroPierro commented 1 year ago

Objective of pull request: fix initialization of refract_counter to match expected behaviour

Pull request checklist

Your PR fulfills the following requirements:

[x] Issue created that explains the change and why it's needed
[x] Tests are part of the PR (for bug fixes / features)
[x] Docs reviewed and added / updated if needed (for bug fixes / features)
[x] PR conforms to Coding Conventions
[x] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
[x] Lint (pyb) passes locally
[x] Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type: - [x] Bugfix ## What is the current behavior?

refract_counter was initialized to 0 in NEBM and NEBMSA processes, resulting in the model not entering in refractory period after the first spike

What is the new behavior?

-refract_counter is correctly initialized, based on the value of refract and refract_scaling

Does this introduce a breaking change?

[x] No