Merge satellite scheduler and fix QUBOSolver convergence on CPU

tim-shea commented 1 year ago

Issue Number: #213

Objective of pull request: Merge satellite scheduler and fix QUBOSolver convergence on CPU

Pull request checklist

Your PR fulfills the following requirements:

[X] Issue created that explains the change and why it's needed
[X] Tests are part of the PR (for bug fixes / features)
[X] Docs reviewed and added / updated if needed (for bug fixes / features)
[X] PR conforms to Coding Conventions
[X] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
[X] Lint (pyb) passes locally
[X] Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

[X] Bugfix
[X] Feature

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

[X] No

tim-shea commented 1 year ago

Thanks @tim-shea for the contribution, looks good overall!

I left a couple of minor comments.

What about moving satellite_scheduler.py in the utils/generators folder?

I'm open to doing that too. Not sure if it's very useful as a general piece of code, but perhaps with some refactoring.

AlessandroPierro commented 1 year ago

Thanks for your work, feel free to merge!

—Alessandro

On Mon, 24 Jul 2023 at 21:21, Tim Shea @.***> wrote:

@tim-shea https://github.com/tim-shea requested your review on: #241 https://github.com/lava-nc/lava-optimization/pull/241 Merge satellite scheduler and fix QUBOSolver convergence on CPU.

— Reply to this email directly, view it on GitHub https://github.com/lava-nc/lava-optimization/pull/241#event-9903793432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTYJUWAOGTPI5VANMJRXSLXR3DJ7ANCNFSM6AAAAAA2OP4HIA . You are receiving this because your review was requested.Message ID: @.***>

lava-nc / lava-optimization