lava-nc / lava

A Software Framework for Neuromorphic Computing
https://lava-nc.org
Other
555 stars 143 forks source link

CLP Tutorial 02: COIL-100 #721

Closed elvinhajizada closed 1 year ago

elvinhajizada commented 1 year ago

Issue Number:

706

Objective of pull request: Create the first tutorial on the initial version of CLP (Continually Learning Prototypes) algorithm, explaining how to set up and use the CLP processes from #706

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Supplemental information

elvinhajizada commented 1 year ago

Please ignore everything except the new tutorial notebook

weidel-p commented 1 year ago

I will review that in more detail, but I already saw some minor things you could change.

  1. images should not go in this repository directly but should go here: https://github.com/lava-nc/lava-nc.github.io/tree/main/_static/images . This is to avoid the lava repository growing bigger.
  2. Your tutorials are called tutorial01 and tutorial03. Is there a tutorial02 still coming? Otherwise relabel.
  3. Usually, we have this "do you want to learn more" and "how to stay in contact" footer in our tutorials. Could you add them?
  4. Add your tutorials to the test pipeline here: tests/lava/tutorials/test_tutorials.py
weidel-p commented 1 year ago

I added comments to the tutorials and started a PR to your branch. https://github.com/elvinhajizada/lava/pull/1

PhilippPlank commented 1 year ago

Tutorials use sklearn module, which is currently not part of lava.

elvinhajizada commented 1 year ago

The significant update to this PR includes:

elvinhajizada commented 1 year ago

The tests for CLP tutorials are commented out temporarily, till sk-learn is added to CI. Once that happens, I will add these tests before merge