Re-adding deprecated lava.utils.system. - Githubissues

lava-nc / lava

A Software Framework for Neuromorphic Computing

https://lava-nc.org

Other

535 stars 136 forks source link

Re-adding deprecated lava.utils.system. #739

Closed tim-shea closed 12 months ago

tim-shea commented 12 months ago

Issue Number: #738

Objective of pull request: Re-add lava.utils.system to fix errors in libs and lava-loihi. Mark as deprecated.

Pull request checklist

Your PR fulfills the following requirements:

[X] Issue created that explains the change and why it's needed
[X] Tests are part of the PR (for bug fixes / features)
[X] Docs reviewed and added / updated if needed (for bug fixes / features)
[X] PR conforms to Coding Conventions
[X] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
[X] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
[X] Build tests (pytest) passes locally

Pull request type

Please check your PR type:

[X] Bugfix

What is the current behavior?

Deleting lava.utils.system in PR #685 broke things in libs and lava-loihi.

What is the new behavior?

The module is no longer deleted, just marked as deprecated.

Does this introduce a breaking change?

[X] No