Open kds300 opened 10 months ago
Hi @kds300, Thanks for this PR. Sorry it took us so long to take a look.
Pushed a PR to https://github.com/kds300/lava/pull/7 that should fix the codacy issues.
I will do more review in the next few days and I've added a few others for comment and review.
Thanks for your contribution. Great code quality!
Just a few minor points I would ask you to change.
Please reach out if you have any questions.
Thanks for the feedback! I'll go through code and make the requested changes.
I updated my local branch with several of the recommended changes, and commented on some of the requested changes that I have questions about.
Hi @kds300, Thanks for this PR. Sorry it took us so long to take a look.
Pushed a PR to kds300#7 that should fix the codacy issues.
I will do more review in the next few days and I've added a few others for comment and review.
@mgkwill Thanks for fixing the codacy issues! I'm still a bit new to github, especially using it collaboratively, so I had started making changes before merging that pull request. I added a commit to sort out some of the merge conflicts I created and then merged the pull request.
Issue Number: #775
Objective of pull request: Add Plateau neuron model to lava as described in the above issue.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information