lava-nc / lava

A Software Framework for Neuromorphic Computing
https://lava-nc.org
Other
529 stars 136 forks source link

Add BitCheck Process #802

Closed mgkwill closed 8 months ago

mgkwill commented 8 months ago

Issue Number: #801

Objective of pull request: Add a BitCheck process. This short and simple ProcessModel can be used for quick checking of bit-accurate process runs as to whether bits will overflow when running on hardware.

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type: - [X] Feature ## What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Supplemental information

During Loihi verification against Lava bit-accurate simulation we found that it was useful to have an overflow checker. This PR and feature request is the result of that realization.

Suggestions and design ideas happily accepted.

mgkwill commented 8 months ago

Looks great Marcus. Feel free to incorporate the dynamic shape identification during connect_var that we discussed.

Thanks @bamsumit will make that change.

mgkwill commented 8 months ago

Looks great Marcus. Feel free to incorporate the dynamic shape identification during connect_var that we discussed.

Hi @bamsumit - I've refactored to set shape using connect_var. Let me know if what I've done works, or you have any other thoughts?

bamsumit commented 8 months ago

Looks great Marcus. Feel free to incorporate the dynamic shape identification during connect_var that we discussed.

Hi @bamsumit - I've refactored to set shape using connect_var. Let me know if what I've done works, or you have any other thoughts?

@mgkwill That is perfect :)

mgkwill commented 8 months ago

Thanks @PhilippPlank and @bamsumit for the feedback!

Fixed all issues.