[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation changes
[ ] Other (please describe):
What is the current behavior?
The PyLifRefractoryModelFloat model does not update the voltage correctly in its sub-threshold dynamics. The current equation is:
Therefore, the voltage of the neurons is updated incorrectly.
What is the new behavior?
The correct dynamics of the voltage should be:
so the new behavior uses this new equation.
Does this introduce a breaking change?
[ ] Yes
[x] No
Supplemental information
The unit test related to the Refractory model confirmed that the voltage remains at 0 during the refractory state. However, the expected voltage array is incorrect, so it was also modified.
Issue Number: #841
Objective of pull request: Fix the
PyLifRefractoryModelFloat
voltage dynamics.Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:What is the current behavior?
PyLifRefractoryModelFloat
model does not update the voltage correctly in its sub-threshold dynamics. The current equation is: Therefore, the voltage of the neurons is updated incorrectly.What is the new behavior?
Does this introduce a breaking change?
Supplemental information
The unit test related to the Refractory model confirmed that the voltage remains at 0 during the refractory state. However, the expected voltage array is incorrect, so it was also modified.
Closes #841