lava-nc / lava

A Software Framework for Neuromorphic Computing
https://lava-nc.org
Other
529 stars 136 forks source link

Fix: subthreshold dynamics equation of refractory lif #842

Closed monkin77 closed 2 weeks ago

monkin77 commented 3 months ago

Issue Number: #841

Objective of pull request: Fix the PyLifRefractoryModelFloat voltage dynamics.

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Supplemental information

The unit test related to the Refractory model confirmed that the voltage remains at 0 during the refractory state. However, the expected voltage array is incorrect, so it was also modified.

Closes #841

jlubo commented 3 months ago

Hi, just to support this, in the Brian2Lava project we have used the same fix and it works well.

monkin77 commented 1 month ago

@mgkwill @bamsumit I would like to request a review of this PR. It's a quick hotfix on the refractory LIF behavior.