lava / dockermail

Ready-to-use email server + (optional) web mail + (optional) caldav, carddav and a kitchen sink in a docker container
MIT License
301 stars 59 forks source link

Improve docker intermediate images #30

Closed jkliff closed 8 years ago

jkliff commented 8 years ago
lava commented 8 years ago

This looks very nice, but why are you removing /var/lib/apt/lists/* in every Makefile? Shouldn't it be enough to do it in mail-base?

jkliff commented 8 years ago

If not removed it will be included in the overlays increasing needlessly their size. Arguably, the tradeoff is that one has to apt-get update again at each Dockerfile, which might increase the build time; but overlays might need to be stored, published, shared, etc, so keeping their size as small as possible is considered a good practice (see section apt-get on [1]).

[1] https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/

lava commented 8 years ago

Ok then, thanks for contributing!