search

lava / dockermail

Ready-to-use email server + (optional) web mail + (optional) caldav, carddav and a kitchen sink in a docker container
MIT License
300 stars 60 forks source link

Updating repo and merging improvements #9

Open gegere opened 9 years ago

gegere commented 9 years ago

Greetings @lava, I wanted to email you directly but this is not an option. I have made several improvements to this repo and was wondering if you would be interested in having a look. Maybe I could issue a pull request and we could join efforts to make a better IMAP server / Mail server docker solution, I believe these updates will help others. Cheers!

dragonito commented 9 years ago

Hi @gegere

what improvements did you made?

Cu

Robin

gegere commented 9 years ago

@dragonito sorry for the delay.

The idea was to take much of the configuration and file edits out of the Dockerfile and put them into a process file which will run when the system is started. Reducing many commits / hash within the Docker container.

Here is a basic overview regarding the updates I have made:

The creation of a Makefile to help with the different configuration options and help other looking to learn docker understand more of the possible options.

Unit testing is another important aspect I have started with this pull request. Using two of the best online best services that support the creation of Docker containers, Shippable & CircleCi. I would like to continue to improve this.

Running this system on CoreOS or a local dev environment required the addition of supervisord which will allow various tasks to run continuously in the background.

There were other tweaks, but hopefully this overview helps. I am using this system in production and it works great. I still plan to update the commit and improve the PR based on the request of @lava