search

lavab / api

Lavaboom's main backend API.
https://lavaboom.com
23 stars 11 forks source link

Threads are identified by subject line if no references exist #129

Closed mlooz closed 9 years ago

mlooz commented 9 years ago

This sometimes creates problems. Steps to reproduce:

  1. Write email from first external account (alice@example.com) with subject "Invoice" to lavaboom account
  2. Write email from second external account (bob@example.com) with subject "Invoice" to lavaboom account

What happens: Emails from Alice and Bob are shown in one thread, even though they don't have anything to do with each other.

This also happens in practice, for example all "Undelivered emails returned to sender" messages are aggregated into one thread.

Appears to be duplicate of #127, sorry.

mlooz commented 9 years ago

Suggested solution: Remove lines 697 - 714 of https://github.com/lavab/mailer/blob/master/handler/handler.go What do you think, @andreis @pzduniak ?

pzduniak commented 9 years ago

Added a members check in lavab/mailer@23e44e585790884bc469e7cc87deb112e63bac1f. Please check if it's fine now, then I might also add a time check.

pzduniak commented 9 years ago

I'll just close it for now. We'll reopen if someone notices a bug related to it.

andreis commented 9 years ago

andreis removed the in progress label 4 hours ago

Wtf? I didn't do that, is it because of CodeTree?

pzduniak commented 9 years ago

im just sitting here stealing your cookies and removing labels

mlooz commented 9 years ago

The initial bug of https://github.com/lavab/web/issues/552 still occurs when both emails are from the same sender. Steps to reproduce:

  1. Send email with subject "Invoice" from external account to lavaboom account
  2. Move email to trash within lavaboom
  3. Send second email with subject "Invoice" from same external account

What happens: second email is also sorted into trash, never occuring in inbox.

pzduniak commented 9 years ago

I'll solve that issue in as lavab/web#552

2015-05-17 23:08 GMT+02:00 mlooz notifications@github.com:

The initial bug of lavab/web#552 https://github.com/lavab/web/issues/552 still occurs when both emails are from the same sender. Steps to reproduce:

  1. Send email with subject "Invoice" from external account to lavaboom account
  2. Move email to trash within lavaboom
  3. Send second email with subject "Invoice" from same external account

What happens: second email is also sorted into trash, never occuring in inbox.

— Reply to this email directly or view it on GitHub https://github.com/lavab/api/issues/129#issuecomment-102858496.

Piotr Zduniak piotr@zduniak.net http://zduniak.net

andreis commented 9 years ago

That sounds like a backend issue, if the emails are actually attached to the same thread.