lavab / web

AngularJS web client of Lavaboom's email service
https://mail.lavaboom.com
38 stars 21 forks source link

Style notifications #345

Open let4be opened 9 years ago

let4be commented 9 years ago

I've added notifications support for showing that user's attention required Currently it displays warning if user has no proper support for web crypto or web workers

see: https://github.com/lavab/web/blob/develop/src/index.jade#L49-49 https://github.com/lavab/web/blob/develop/src/blocks/inbox/emails.jade#L8-8

Need to design how it should look like && style this, currently it's just a draft

let4be commented 9 years ago

What do we have now?

Login/signup application: image

and

primary application: image

vLooz commented 9 years ago

What is web crypto and web workers and what is it used for? @let4be

vviikk commented 9 years ago

its a script that is available in newer versions of browsers. without it, standard javascript is used to decrypt the email. and this can sometimes take minutes for an email with a small image in it.

basically, its a warning to the user saying 'Webcrypto not found. Decrypting may take a long time.'

alternative ways of saying it: 'Lavaboom may run slowly (why?)' - and link 'why' to another page on our help site or something.

vLooz commented 9 years ago

Does Webcrypto comes automatically with up to date browsers or do users need to install it manually?

let4be commented 9 years ago

In modern browsers both should be enabled by default.

There is also a development-only case when some functions aren't available due to lavaboom is being accessed via wrong address(such as 0.0.0.0, instead of proper domain name with https support or localhost)

let4be commented 9 years ago

http://caniuse.com/#feat=cryptography http://caniuse.com/#feat=webworkers

vLooz commented 9 years ago

Ok, for those older browser, where this is not available, what can the user do to change it?

let4be commented 9 years ago

upgrade ;)

vLooz commented 9 years ago

How about this?

This bar is shown every time, when a photo needs longer than x seconds to be decrypted and the user doesn't have the newest browser version. When you hit ok, the bar disappears, but only for this specific mail. What do you think @flixi

webcrypto slow notification

vviikk commented 9 years ago

sadly, you wont be able to see that message in that position, because once the email starts decrypting without webcrypto, all other javascripts on the page stops running. you cant click on anything neither can we display or do anything - everything stops working during this state. for now, i think show a prompt with an ok button upon login would be the most ideal solution. or even during login, we can check and inform the user that the app is going to be slow, and opening emails with images can cause the browser to become unresponsive.

vviikk commented 9 years ago

i think it should just be an extra step after login saying

Your browser doesn't support WebCrypto Please upgrade your browser or use one of the following:

_You can still use Lavaboom. Please note that decrypting emails with images may take some time_ [Proceed] [Cancel]
vviikk commented 9 years ago

however we do need to show notifications. informative notifications, that don't require user interaction. such as the one you see when you save/update a contact.

flixi commented 9 years ago

I like the idea from @piggyslasher to include a thing right after login with the user being able to sign out if he choses to do so...

vviikk commented 9 years ago

then we shall just make the webcrypto notification after login.

@let4be just add the class '.navbar-text' if you wanna display notifications in the black area :) its a toolbar that auto-resizes the text.

edit but i found where you're doing the notifications now. i just need to edit /services/notifications.js ya?

vviikk commented 9 years ago

@let4be - can you give me an example of when this notification will be used? if we're already warning users during the login process?

vviikk commented 9 years ago

maybe external images

image

vLooz commented 9 years ago

These are the places, where we can show notifications. I think we should keep them consistent. Meaning: when there is a problem, regarding the whole account, we show it as early as possible in the login process. When there is a problem regarding only one specific element in an email, we show it in the email.

notificationhierarchyscheme

let4be commented 9 years ago

@piggyslasher I've added remove notification to your button,but now I see this: image

let4be commented 9 years ago

also having "You server today is Darth Vader, happy mailing" over my email I find this annoying... probably we need to move this to a better place?

vLooz commented 9 years ago

See #384

vviikk commented 9 years ago

the content of the notification was just so i have something style @vLooz

@let4be let me check.

let4be commented 9 years ago

From my side it's finished

vviikk commented 9 years ago

@flixi - Boss request to move this to 2.1 because for now we have 3 kinds of notifications

Other notifications that I have to style are all 2.1 in other issues (some of which Ive completed when I was working on something related).

joergG commented 9 years ago

@piggyslasher - how is the status here?