lavab / web

AngularJS web client of Lavaboom's email service
https://mail.lavaboom.com
38 stars 21 forks source link

Settings-keys new layout isues #446

Closed let4be closed 9 years ago

let4be commented 9 years ago

image

  1. Send public key 1.a. fix the icon 1.b. what is the purpose of this button? (I have no idea)

~~2. Clicking on image has no effect in collapse/unfold - need to fix~~ This seems to be working.

3. Algorithm field is empty

vLooz commented 9 years ago

Friendly reminder that I'd like it to look like this ;-) The "3." only appears if there are 3 key pairs saved. If there is only one, there is no number and the field next to the keypair icon is blanc. No date here please. bildschirmfoto 2015-04-10 um 15 57 54 Regarding 1b.: We need to be able to send a public key to a non-lavaboom recipient somehow. Thats what this button is for. If it's not safe, we need to come up with another option, otherwise we will become much less attractive to a lot of early adopters (just my POV)

flixi commented 9 years ago

bildschirmfoto 2015-04-13 um 11 28 11

flixi commented 9 years ago

https://gist.github.com/flixi/0d1f3581d244ad4224d6

vLooz commented 9 years ago

I have the same gibberish. This styleguide is out for almost a month. If they are any problems or doubts preventing you from implementing the key section exactly(!) like this, please let me know. If not, please adjust the UI to my styleguide asap! @piggyslasher :-) As far as I see it, your orange and blue buttons below the key sections are not necessary at all, because all the functions are covered by the options in the styleguide. Please correct me if I am wrong here. 2015-03-18_settings_keys_dialogs

vviikk commented 9 years ago

this is how it looks on my side.

image

I'm not sure why you're seeing gibberish. @andreis - can you make sure @vLooz is on the latest?

Theres more refinements to do but yes. the collapse/expand system works.

vviikk commented 9 years ago

i've tried all known browsers on Mac and cannot replicate this issue. are you guys using a local copy? or the develop branch? or .com or .co?

here's the latest: image

@let4be have we decided on the 'decrypted' field? To be honest I'm only following @vLooz's layouts and the decryption system was not there in the latest mockups. Can you please discuss and let me know if it is necessary?

Also - regarding the expiry date. Do we have this?

vviikk commented 9 years ago

@vLooz :

As far as I see it, your orange and blue buttons below the key sections are not necessary at all, because all the functions are covered by the options in the styleguide. Please correct me if I am wrong here.

I never added these buttons. The were added by @let4be

Now we have the + and - buttons but you only refer to them for pro users. So I'm really not sure what to do here.

What I've done so far is this. I've styled whatever I can to include all the functionality that you've added to your final mockup.

here's what the latest work looks like:

image

vviikk commented 9 years ago

pull request #478 closed.

mlooz commented 9 years ago

Commenting here since the other one was a duplicate. I'm working on the .com version with Firefox on Ubuntu 14.04.

Setting style="overflow: hidden" works!

Toggling the key information now changes the style from "overflow: hidden; height: 0px;" to "style="overflow: hidden; height: auto;" and back, both looking as they should. :-)

vviikk commented 9 years ago

i believe youre seeing an older version on .com - there's tones of small fixes I did over the weekend. why dont you pull fresh from git?

you wont have this issue if you use the latest version.

https://github.com/lavab/web has the instructions on how to setup. It is actually very easy.

git clone https://github.com/lavab/web.git && cd ~/web/ && git checkout develop && npm install --global gulp && npm install && gulp

once youre done, you can access the latest version on you local server http://127.0.0.1:5000

mlooz commented 9 years ago

I had to strongarm gulp into accepting an older node.js version, but now it works and looks right. Thanks! :-)

This was on a local copy of the development branch, version 0.2.3.

vLooz commented 9 years ago

I did indeed looked at the .com version instead of your local branch @piggyslasher. Apologies for giving unfair feedback because of this! Even though the .com version is what beta testers see and test right now. I doesn't make much sense to let them give feedback to a version, that is not up to date, right? I've just talked to FMI about this and I think we need to get the deployment to .com quicker or at least more structured. Otherwise I see people commenting on old versions happening over and over again.

vviikk commented 9 years ago

I know. Last time the mail.lavaboom.co version was up to date with my changes on the development branch. Now its not automatic anymore. I don't really want to update the .com myself as @let4be should do that. He's more well versed with whats working underneath and whats not.

@pzduniak - any idea about when .co will reflect develop?

vviikk commented 9 years ago
vviikk commented 9 years ago

assigning to @let4be for those extra fields.