lavab / web

AngularJS web client of Lavaboom's email service
https://mail.lavaboom.com
38 stars 21 forks source link

Settings/Keys: New KeyPair Visualisation #759

Open vLooz opened 9 years ago

vLooz commented 9 years ago

I got comments from some users, that the actual KeyPairs are not shown in a intuitive way. I've been working on a new UI to hopefully improve that.

It's could be seen as a continuation of https://github.com/lavab/web/issues/326 and is obviously connected to https://github.com/lavab/web/issues/737

Whats different now? The KeyPair are still shown in 2 states, collapsed and expanded view. Even though the collapsed view now shows more about the KeyPair logic - being made of Public and Private - and offers all the buttons a normal user needs right away. When the user wants to learn more about the keys, actually wants to see them or wants to do more fancy stuff like deleting etc. there is a new edit mode now for them. This edit mode is only accessible when the user has switched on advanced settings first.

First mock shows the normal collapsed view (top), a keypair that has expired (middle) and a keypair in edit mode (bottom) 2015-05-19_settings_keys new-01

The second mock shows the KeyPair collapsed and expanded all way down, showing keypair info, the public key and the private key. 2015-05-19_settings_keys new-02

vLooz commented 9 years ago

This mock shows a encrypted KeyPair. Note the additional button "decrypt"

2015-05-19_settings_keys new-03

vLooz commented 9 years ago

This mock shows the edit-view of an partially expanded KeyPair. Note the difference between the grey "header" in this mock and the grey "background" in the collapsed edit mode (3. KeyPair on the first mockup-sheet).

2015-05-19_settings_keys new-04

vLooz commented 9 years ago

Find the new icons (e.g. encrypted KeyPair etc.) here on Trello: https://trello.com/c/b9f8tDxd/46-updated-key-icons

vviikk commented 9 years ago

so we only show the delete icon if item is expanded. yes?

vLooz commented 9 years ago

No, sorry for the confusion. We can show it in both states. The upper mock shows the collapsed state, in the lower mock, the keypair info is expanded.

2015-05-19_settings_keys new-04-06

vviikk commented 9 years ago

guidelines from @vLooz

image

image

joergG commented 9 years ago

@piggyslasher - just cleaning up the waffle-board. this might be "key management rework" on trello? so implementation is finished?

let4be commented 9 years ago

hm I don't see this is in develop, yet

joergG commented 9 years ago

@piggyslasher - this would best be tested by fvl, right? can we also push it to staging?

vviikk commented 9 years ago

only thing that hasnt been merged. will merge later.

joergG commented 9 years ago

@piggyslasher - just tell us when it's done, so fvl can test this

joergG commented 9 years ago

@piggyslasher?

vviikk commented 9 years ago

@let4be is putting the finishing touches on this. I will then have another look after he's done to fix the encrypted/decrypted styling. I think that is all.

let4be commented 9 years ago

Should work, decrypt key popup probably needs some polishing @piggyslasher

as this is intermediate version I left buttons like "generate new key-pair" on their previous place this will be addressed later

vLooz commented 9 years ago

Good to know you're still on it @let4be. I'll wait with my review then.

let4be commented 9 years ago

@vLooz I'm just saying we probably better do not introduce additional complexity here at the current stage(edit mode, pro mode, etc) and leave everything that possible to the next milestone(premium)

vLooz commented 9 years ago

I agree when it comes to introducing pro mode @let4be. However, from my pov the complexity already is there (additional key functions/buttons), just packaged in a way, that is not fitting the rest of the style. To increase our chances to convince investors, I think the UI should look as neat as possible. But I'm just the designer ;-)

joergG commented 9 years ago

@piggyslasher - so status is that you are styling this atm, right?

vviikk commented 9 years ago

Yes, I am getting everything done now. I needed to rewrite a lot of old code for this.

vviikk commented 9 years ago

More work on this. New guidelines.

image

vviikk commented 9 years ago

We currently don't have an edit mode @vLooz. So should I just ignore that for now? And re-open the issue when we have an edit mode?

vLooz commented 9 years ago

Why do we not have an edit mode @piggyslasher? I told @let4be that we need it and I don't like to skip it a week ago.

vviikk commented 9 years ago

Sorry. Anyway. Have a look at http://lb.Ramanujam.am Use your .com account to login. See the key section under settings.