lavab / web

AngularJS web client of Lavaboom's email service
https://mail.lavaboom.com
38 stars 21 forks source link

Dockerfile #850

Closed let4be closed 9 years ago

let4be commented 9 years ago

use

git fetch --all && git reset --hard origin/master instead of git pull

so we could rollback when needed and use the same deploy command what do you think @pzduniak ?

pzduniak commented 9 years ago

Is there any particular reason for that? If you keep a clean copy of the repo on the server, you can just git pull, docker build and em and then start it. On 10 Jun 2015 13:01, "let4be" notifications@github.com wrote:

use

git fetch --all git reset --hard origin/master instead of git pull

so we could rollback when needed and use the same deploy command what do you think @pzduniak https://github.com/pzduniak ?

— Reply to this email directly or view it on GitHub https://github.com/lavab/web/issues/850.

let4be commented 9 years ago

well I had to do git reset --hard on master today in order to rollback to the previous version in this way git pull didn't fetch this rollback, it simply thought local version has more recent commits

pzduniak commented 9 years ago

It's only a command that you're running. Right now you pretty much have to cd ~/web && git pull && docker build -t "lavab/web" . && docker rm -f web-master && ~/docker/runners/web-master.sh"

let4be commented 9 years ago

oh right, being stupid today ^^