lavab / web

AngularJS web client of Lavaboom's email service
https://mail.lavaboom.com
38 stars 21 forks source link

Style validation errors for password change in settings/security #865

Closed let4be closed 9 years ago

let4be commented 9 years ago

image

vLooz commented 9 years ago

865_changepassword-05

vviikk commented 9 years ago

image

joergG commented 9 years ago

@ALL - also new waffle-rule: when an issue is done (FE,BE,UI) from your pov, you'll do the dev-test and afterwards push it to testing. fvl and me (sometimes andrei) will test it and move it on then!

vLooz commented 9 years ago

Hey @piggyslasher. Do I understand this correctly, that you guys decided to use a reduced UI for the password handling instead of implementing my mocks? just for me to know.

joergG commented 9 years ago

@piggyslasher - like we said in the meeting, it's gonna stay in TESTING until fvl, andrei or I tested it :-) -> In this case it should be @vLooz, right?

joergG commented 9 years ago

@vLooz - could you have a look on staging if this has been implemented correctly, please?

vLooz commented 9 years ago

staging is mail.lavaboom.io, correct @piggyslasher ?

joergG commented 9 years ago

@vLooz - yes

vLooz commented 9 years ago

To be honest, the password change area is more buggy then before. on Mac + Safari it looks like this:

bildschirmfoto 2015-07-15 um 13 36 57
joergG commented 9 years ago

@piggyslasher - did you actually merge this already?

vviikk commented 9 years ago

I merged it into develop but has @let4be put it on staging? And yes, the switch position is off. Fixed, will merge soon.

joergG commented 9 years ago

@piggyslasher - let us know when this is on staging, please.

vviikk commented 9 years ago

It is there. Please check again.

vLooz commented 9 years ago

It's working well from my pov and we can push it to fix the error. Still I would like to see my new UI implemented in the near future :)

joergG commented 9 years ago

@vLooz - what does this mean? is this specific issue solved? then we should push it to "to ship".

vviikk commented 9 years ago

Honestly, all this validation that we're using is redundant. I think we should just use the basic HTML5 validation next time @let4be. No need any angular stuff. Plus this method is completely mobile friendly.

http://www.the-art-of-web.com/html/html5-form-validation/