We need an enumerated type for data type in fields returned by database queries.

lavabit / magma

The magma server daemon, is an encrypted email system with support for SMTP, POP, IMAP, HTTP and MOLTEN,. Additional support for DMTP and DMAP is currently in active development.

GNU Affero General Public License v3.0

1.82k stars 165 forks source link

We need an enumerated type for data type in fields returned by database queries. #32

Open LBiv opened 9 years ago

LBiv commented 9 years ago

Going to put every instance that I see where this replacement needs to occur here:

src/servers/smtp/datatier.c lines 199-232 src/servers/smtp/datatier.c lines 293-300 src/servers/smtp/datatier.c lines 636-647

kenthawk commented 9 years ago

Same code: line 116: int_t smtp_fetch_inbound()

This routine needs enum types for describing the error return values
Also needs enum types for the user record's lock levels that are checked starting line 171. Adding enum for lock levels will require a sweep throughout the codebase to apply that enum to all lock level references, which will require a sweep that's broader than the smtp.c code, right?

LBiv commented 9 years ago

Yes, enums for errors would be nice too.