Document adler32 hashing algorithm

lavabit / magma

The magma server daemon, is an encrypted email system with support for SMTP, POP, IMAP, HTTP and MOLTEN,. Additional support for DMTP and DMAP is currently in active development.

GNU Affero General Public License v3.0

1.82k stars 167 forks source link

Document adler32 hashing algorithm #4

Open rillig opened 9 years ago

rillig commented 9 years ago

The Adler32 checksumming algorithm in src/core/hash/adler.c needs to be documented and verified that it meets its specification. Currently it fails on x86 because char is a signed data type on that platform. See https://github.com/lavabit/libdime/blob/master/check/core/check_hash.c for the check in libdime.

rillig commented 9 years ago

Am 26.05.2015 um 22:46 schrieb Ivan:

I believe this is one of the things that Roland already fixed in libdime/libs/core, but is still an issue in magma.classic.

If you pull down libdime from github and you do a diff between the two files you will see the changes. There is also a unit test that he wrote that he linked to which does not exist in magma.

Confirmed.

Roland