lavabit / robox

The tools needed to robotically create/configure/provision a large number of operating systems, for a variety of hypervisors, using packer.
626 stars 139 forks source link

Fix centos8 kickstart file install locations #180

Closed sivel closed 2 years ago

sivel commented 3 years ago

The way the kickstart file for centos8 is defined, specifies the install method at the start as cdrom, which then causes the installer to abort because the builder doesn't use full install media, just boot media, and cannot find the repo data.

Ultimately this leads to the builder failing at a little over 1 hour, because the installation was hung on a prompt to reconfigure the installation source.

This PR ensures we properly indicate that the install location is from a URL.

In the console on the main tab:

Installation 
1) [x] Language settings                2) [x] Time settings 
       (English (United States))               (US/Pacific timezone)
3) [!] Installation source              4) [!] Software Selection
       (Error setting up software              (Error checking software
       source)                                 selection)
5) [x] Installation Destination         6) [x] Kdump
       (Automation partitioning                (Kdump is enabled)
       selected)
7) [x] Network configuration            8) [ ] User creation
       (Wired (eth0) connected)                (No user will be created)

Please make a selection from the above ['b' to begin installation, 'q' to quit,
'r' to refresh]: 

From /tmp/storage.log:

DEBUG:blivet:no type or existing type for sr0, bailing

I was going to provide more logs, but it's tedious to get the output through the VNC client I'm using. /tmp/syslog also contains note that the cdrom has been unmounted, and /tmp/anaconda.log states PayloadError: Found no CD-ROM

sivel commented 3 years ago

Also, I'm guessing for whatever reason you may not be experiencing this?

Just for context, I am building these directly through upstream packer with no patches, and not using build tooling in this repo. But I cannot see how this change would affect any existing build patterns.

sivel commented 3 years ago

Looks like in 0106e0758e83f739cf912f06f48b82861aafafc2 the build was switched to use the full DVD, and in 82780cc2bfc61cdf59fb140cee9faf9d1e7475a4 the kickstart was updated to only use cdrom, but repo/url was only commented out.

I don't know what the intention is, so I'll leave this open for now.

If you want to keep using the DVD ISO then this can be closed, otherwise, let me know.

ladar commented 3 years ago

@sivel thank you for submitting the fix. Your PR got lost on my TODO list.

I indeed ran into this issue. I think it started hapening when we upgraded the installer from the 8.2 to the 8.3 ISO. At that point repo install broke, and I couldn't figure out why. In the end, I ran out of time, and switched to using the full DVD, and haven't revisited the issue since. But it seems you found the culprit.

I'm hoping to spend a few days focused on various pending Robox tasks sometime in the next 2-4 weeks, at which point I plan to make a number of large changes (namely adding the new box variants listed in the README). I'll try and incorporate this change then, so look for it to be incorporated when the 3.3.x boxes get uploaded.