Closed matoro closed 8 months ago
Hi @matoro ... thank you for submitting these improvements. I will take a look soon, but based on your description, I don't see any issues. Just curious though, have you tried building the updated config on any of the hypervisors? I recall the details, but I think the Python priority was added to workaround build problems with some of the packages installed. I don't recall though, if it was one of the guest agents, or not.
If you have time, I'm in the process of adding a Gentoo container build config to the pipeline, so I can build Docker/Podman images, but I haven't optimized the image/config for use as a container at all. So any tips/improvements from a Gentoo guru would be appreciated.
Hi @matoro ... thank you for submitting these improvements. I will take a look soon, but based on your description, I don't see any issues. Just curious though, have you tried building the updated config on any of the hypervisors?
Yes, I tested building this on libvirt hypervisor.
I recall the details, but I think the Python priority was added to workaround build problems with some of the packages installed. I don't recall though, if it was one of the guest agents, or not.
The default PYTHON_TARGETS
is supposed to support everything in the official tree. The default doesn't get changed until everything in the tree supports it. So it should never be required to manually set PYTHON_TARGETS
to install any official packages.
If you have time, I'm in the process of adding a Gentoo container build config to the pipeline, so I can build Docker/Podman images, but I haven't optimized the image/config for use as a container at all. So any tips/improvements from a Gentoo guru would be appreciated.
Gentoo already publishes official Docker images so I would absolutely recommend just using those as-is or pulling from them.
Hi, three fixes to items I encountered while working with the Gentoo builds:
The hardcoded PGP key here is expired, curiously I learned while investigating this that gnupg does not consider this a fatal error. Regardless, the official release page provides instructions on how to retrieve the latest signing keys, which are rotated regularly. I added a step which removes expired keys from the keyring before running the verification step and checked that this does indeed fail the build if the keys are expired.
There is no need to include a fragile manual kernel configuration, which becomes more out of date as features are added and defaults changed. Gentoo now provides official distribution kernels which are very comprehensive. I used the binary package to speed up the build a little here, but you can swap to
sys-kernel/gentoo-kernel
if you want to build it from source.Python 2.7 and 3.8 have long been removed as valid Python targets. The profile tree already contains consistent default Python targets, so there is no need to specify them manually. This was causing the world update to get skipped.
I split these up into separate commits in order to make it easier to inspect each change individually. I also was not sure about the magma variant, does that actually get built anymore? I did not see it on Vagrant Cloud.