lavabit / robox

The tools needed to robotically create/configure/provision a large number of operating systems, for a variety of hypervisors, using packer.
620 stars 140 forks source link

Gentoo: misc fixes #285

Closed matoro closed 8 months ago

matoro commented 9 months ago

Hi, three fixes to items I encountered while working with the Gentoo builds:

I split these up into separate commits in order to make it easier to inspect each change individually. I also was not sure about the magma variant, does that actually get built anymore? I did not see it on Vagrant Cloud.

ladar commented 9 months ago

Hi @matoro ... thank you for submitting these improvements. I will take a look soon, but based on your description, I don't see any issues. Just curious though, have you tried building the updated config on any of the hypervisors? I recall the details, but I think the Python priority was added to workaround build problems with some of the packages installed. I don't recall though, if it was one of the guest agents, or not.

If you have time, I'm in the process of adding a Gentoo container build config to the pipeline, so I can build Docker/Podman images, but I haven't optimized the image/config for use as a container at all. So any tips/improvements from a Gentoo guru would be appreciated.

matoro commented 9 months ago

Hi @matoro ... thank you for submitting these improvements. I will take a look soon, but based on your description, I don't see any issues. Just curious though, have you tried building the updated config on any of the hypervisors?

Yes, I tested building this on libvirt hypervisor.

I recall the details, but I think the Python priority was added to workaround build problems with some of the packages installed. I don't recall though, if it was one of the guest agents, or not.

The default PYTHON_TARGETS is supposed to support everything in the official tree. The default doesn't get changed until everything in the tree supports it. So it should never be required to manually set PYTHON_TARGETS to install any official packages.

If you have time, I'm in the process of adding a Gentoo container build config to the pipeline, so I can build Docker/Podman images, but I haven't optimized the image/config for use as a container at all. So any tips/improvements from a Gentoo guru would be appreciated.

Gentoo already publishes official Docker images so I would absolutely recommend just using those as-is or pulling from them.