search

lavacord / Lavacord

A easy to use Lavalink client that can be used with any discord api wrapper
Apache License 2.0
84 stars 21 forks source link

[Fix/Docs] Do not set LavalinkNode.ws as null in LavalinkNode.destroy #93

Closed PapiOphidian closed 3 years ago

PapiOphidian commented 3 years ago

Setting this as null causes a crash if unhandled when trying to access a property of the ws in another method when the node is actually destroyed. The public LavalinkNode.connect reassigns the LavalinkNode.ws property anyways, which would cause the old data to be swept (if leaving a memory footprint was a concern in the first place).

MrJacz commented 3 years ago

Memory footprint is always a concern